add githug oauth login for grafana

cmu-db · Sep 10, 2020 · 0c471ec · 0c471ec
1 parent df62885
commit 0c471ec
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/deployments/kubernetes/monitoring/grafana/deployment.yml b/deployments/kubernetes/monitoring/grafana/deployment.yml
@@ -43,7 +43,7 @@ spec:
             - name: GF_SERVER_DOMAIN
               value: "{{ service_hostname }}"
             - name: GF_SERVER_ROOT_URL
-              value: "http://{{ service_hostname }}/grafana"
+              value: "https://{{ service_hostname }}/grafana"
             - name: GF_SERVER_SERVE_FROM_SUB_PATH
               value: "true"
             - name: GF_SERVER_HTTP_PORT
@@ -60,4 +60,15 @@ spec:
               valueFrom:
                 secretKeyRef:
                   name: secrets-k8s-master
-                  key: gf_admin_password
+                  key: gf_admin_password
+            #GitHub Login
+            - name: GF_AUTH_GITHUB_CLIENT_ID
+              valueFrom:
+                secretKeyRef:
+                  name: secrets-k8s-master
+                  key: gf_auth_github_client_id
+            - name: GF_AUTH_GITHUB_CLIENT_SECRET
+              valueFrom:
+                secretKeyRef:
+                  name: secrets-k8s-master
+                  key: gf_auth_github_client_secret
diff --git a/deployments/kubernetes/monitoring/grafana/service.yml b/deployments/kubernetes/monitoring/grafana/service.yml
@@ -4,7 +4,7 @@ kind: Service
 apiVersion: v1
 metadata:
   name: grafana-service
-  namespace: performance
+  namespace: monitoring
   labels:
     app: grafana
 spec: