Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigates bug with opened locked lockers #8371

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Feb 5, 2025

About the pull request

It's possible for lockers to be both opened and locked at the same time, and the code won't let you close or unlock them in this state. I don't know what allows them to be opened and locked in the first place (probably an issue with the automatic stuff that happens when going to and from red alert). In any case we should let people unlock if this happens.

Explain why it's good for the game

mitigates bug

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: mitigates bug where you can't close or unlock an opened locked locker
/:cl:

@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Feb 5, 2025
@zzzmike
Copy link
Contributor Author

zzzmike commented Feb 5, 2025

draft while github takes forever to run checks

@zzzmike zzzmike marked this pull request as draft February 5, 2025 22:02
@zzzmike zzzmike marked this pull request as ready for review February 5, 2025 23:04
@realforest2001 realforest2001 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into cmss13-devs:master with commit da23c4b Feb 5, 2025
32 checks passed
cmss13-ci bot added a commit that referenced this pull request Feb 5, 2025
@zzzmike zzzmike deleted the patch-14 branch February 6, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants