Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stat Browser not restoring font size #8267

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jan 28, 2025

About the pull request

This PR updates statbrowser to utilize byondstorage (516) to restore and save the font size.

Also of note, this PR requires 516.1652+ because of https://www.byond.com/forum/post/2961371 buuut that version has rendering issues soo hopefully that'll eventually be fixed. Otherwise the changes will just be trampled by chat.

Unfortunately I can't properly reuse storage.js here because its not a proper TGUI window (I guess for compatibility reasons) so I had to reimplement all the extras nuances to reading a value...

Explain why it's good for the game

Preferences should be saved and restored properly.

Changelog

🆑 Drathek
fix: Fixed stat browser not saving/restoring font size value on 516
/:cl:

@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Fix Fix one bug, make ten more labels Jan 28, 2025
@hry-gh hry-gh added this pull request to the merge queue Jan 30, 2025
Merged via the queue into cmss13-devs:master with commit edc3aed Jan 31, 2025
30 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 31, 2025
@Drulikar Drulikar deleted the fix_statbrower_font_saving branch January 31, 2025 00:48
@hry-gh hry-gh added this to the 516 Compatibility milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more UI deletes nanoui/html
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants