Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports "Adds a Chat Reliability Layer" 2: The Reliabaling #8264

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Jan 27, 2025

About the pull request

Possibly it didn't work before because of a misname var that wasn't caught lol

Credit to tgstation/tgstation#79479 and tgstation/tgstation#79819
Everyone knows that chat will just eat your messages now and then, isn't that annoying?
What if SSchat was smart enough to keep track of your messages and notice when you didn't get one?
Well, now it can!

Explain why it's good for the game

Chat messages poofing into the aether is bad, really bad.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ZephyrTFA, san7890
add: Chat Reliability Layer
code: TGUI chat messages now track their sequence and will be resent if the client notices a discrepenency
/:cl:

@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Feature Feature coder badge Code Improvement Make the code longer labels Jan 27, 2025
@private-tristan
Copy link
Contributor

fixes #64?

cm13-github added a commit that referenced this pull request Jan 28, 2025
cm13-github added a commit that referenced this pull request Jan 28, 2025
cm13-github added a commit that referenced this pull request Jan 28, 2025
cm13-github added a commit that referenced this pull request Jan 28, 2025
cm13-github added a commit that referenced this pull request Jan 28, 2025
cm13-github added a commit that referenced this pull request Jan 29, 2025
cm13-github added a commit that referenced this pull request Jan 29, 2025
cm13-github added a commit that referenced this pull request Jan 29, 2025
cm13-github added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge UI deletes nanoui/html
Projects
Status: Awaiting Review
Development

Successfully merging this pull request may close these issues.

2 participants