improved job code TM first #8254
Conversation
cmss13-ci
bot
added
Quality of Life
code/game/jobs/slot_scaling.dm
Outdated
| @@ -7,49 +7,7 @@ | |||
|
|
|||
| // https://docs.google.com/spreadsheets/d/1PlnIwKhq-bVWWFPoBrzWYh1mWK04pyBSQUtUMEw3qSw/edit#gid=1290768907 | |||
|
|
|||
| /proc/job_slot_formula(marine_count, factor, c, min, max) | |||
| /proc/job_slot_formula(marine_count, marine_per_slot, factor, min, max) | |||
There was a problem hiding this comment.
Factor isn’t very descriptive, it’s a constant. Not a factor
There was a problem hiding this comment.
it is not constant and describing what it does is... complicated and I do not know any proper word to describe it... and it was c before
There was a problem hiding this comment.
it is a constant. only weird thing it does is not apply when marine_count < marine_per_slot
There was a problem hiding this comment.
I have just kept that part, yes it is strange indded, but in general you assume that the constant is less then min, else you have wrong min value. so in that seonce it is set correctly
Co-authored-by: TheGamerdk <[email protected]>
…max values and with total_positions_so_far
…max values and with total_positions_so_far
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
realforest2001
added
the
Needs Testing
About the pull request
Aims to make job assignment code more readable, and simplifies the code. you only need to set min max pop per slot and how many steps are not needed for first increment and it works
Explain why it's good for the game
medic and engi slots are increased one by one not 4 at a time.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
qol: medic and engi slots are added one by one not four at a time
code: removes crazy repeated code in jobslot assignment
/:cl: