Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commanding Officer Career paths [rp fluff] #8253

Merged
merged 12 commits into from
Feb 4, 2025

Conversation

Red-byte3D
Copy link
Contributor

@Red-byte3D Red-byte3D commented Jan 26, 2025

About the pull request

Adds a bunch of career paths for CO's to choose from.
practical revive of #3999 with HOPEFULLY better code (probably not)

Explain why it's good for the game

RP Fluff, requested by senator and cool stuff is always cool.

Testing Photographs and Procedure

image

image

image

Changelog

🆑
add: Adds a bunch of career options for the commanding officer whitelist, currently only used for fluff and RP.
/:cl:

@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Jan 26, 2025
Co-authored-by: ihatethisengine <[email protected]>
code/modules/client/preferences.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/uscm_co.dm Outdated Show resolved Hide resolved
@realforest2001 realforest2001 marked this pull request as draft January 26, 2025 18:12
@Red-byte3D Red-byte3D marked this pull request as ready for review January 26, 2025 22:55
@hry-gh hry-gh added this pull request to the merge queue Feb 4, 2025
Merged via the queue into cmss13-devs:master with commit 335eff4 Feb 4, 2025
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Feb 4, 2025
@dadlips
Copy link
Contributor

dadlips commented Feb 5, 2025

I believe there is a bug with this. The commander was in his own "human" faction (on the observer tab). Upon checking his faction var, it was set to "Neutral" on both the "faction" and "faction_group" var. I set both to "USCM" and it seems to have fixed him.

@SevenAte9ine
Copy link

Was the commander that was mentioned. For some reason, I could interact with the CO vendor fine, but I couldn't access the tacmap, was lacking the overhead icon, and was setting off MDs. Even afterward, I was still having the MD and icon problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

6 participants