Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When 2 Chargers Collide, they cause a tremor #8200

Merged

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Jan 21, 2025

About the pull request

When 2 chargers with the TRAIT_CHARGING (actively charging) hit eachother, it causes a tremor to all nearby marines (1s stun/slow).

Reduced the stun from 2 seconds to 1 second for both chargers.

Explain why it's good for the game

Currently, if 2 charger crushers collide on the frontline, they're stunned for 2 seconds and generally immediately die to bullets because of a fellow T3 STUNNING FOR TWO SECONDS (For reference, AP direct hit is a 3 second stun), typically right infront of the marine deathball.

With this change, it stuns/slows nearby marines to give chargers a chance to escape (as well as looking neat)

Testing Photographs and Procedure

Note: In the tests the charger has TRAIT_CHARGING so that I could test it, there is not a stun if you hit a stationary charger crusher or base strain crusher.

Pvp.Cm.Charger.Crusher.Collision.Changes.mp4

Changelog

🆑
add: When 2 charger crushers collide, they now cause a tremor, knocking down and slowing nearby enemies
balance: reduced charger collision weaken (to the charger crushers) by 1 second
/:cl:

@cmss13-ci cmss13-ci bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jan 21, 2025
@hry-gh hry-gh added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 23, 2025
@hry-gh hry-gh added this pull request to the merge queue Jan 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 24, 2025
@hry-gh hry-gh added this pull request to the merge queue Jan 27, 2025
Merged via the queue into cmss13-devs:master with commit 1f32670 Jan 28, 2025
30 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants