Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds scrolling to Overwatch(OW) Consoles #8103

Merged
merged 12 commits into from
Jan 17, 2025

Conversation

MistChristmas
Copy link
Contributor

@MistChristmas MistChristmas commented Jan 14, 2025

About the pull request

Quality of Life (one line change, one word addition) So much for that. No longer do you need to set your second monitor vertical to see the all the Squad, you can simply use the mouse wheel at your leisure.

Old Change: Although I've noticed (example on the screenshot below) that the CRT Effect only scales to the window size, not the contents but doesn't move with the scroll. Which uhh is a little noticeable.

Took more jiggling that I care to mention, but it mostly works. Window can be resized at least on my machine testing without too jarring of an effect. CRT Effect doesn't leave part way down, and of course the scroll works. And I moved it to just the Table of marines.

Additionally the changes I made pushed the Supply and OB sections to the bottom of the window so small change to them to not do that, I doubt many people will notice the difference.

Explain why it's good for the game

SOs without vertical monitors no longer need to be burning with jealousy of those that do and can see all the riflemen they don't really care about.

Testing Photographs and Procedure

Screenshots & Videos
Old Change

Screenshot 2025-01-13 122452

Current

Screenshot 2025-01-16 041953

Screenshot 2025-01-16 042023

Screenshot 2025-01-16 042028

Additional

Screenshot 2025-01-16 042630

Screenshot 2025-01-16 042632

Changelog

🆑 MistChristmas
qol: OW Consoles are scrollable
fix: Fixed eslint not checking jsx files
/:cl:

@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Quality of Life Make the game harder to play labels Jan 14, 2025
@MistChristmas MistChristmas marked this pull request as draft January 15, 2025 15:18
@MistChristmas MistChristmas marked this pull request as ready for review January 16, 2025 04:33
@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Jan 17, 2025
@Drulikar Drulikar added this pull request to the merge queue Jan 17, 2025
Merged via the queue into cmss13-devs:master with commit c29a18b Jan 17, 2025
29 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Quality of Life Make the game harder to play UI deletes nanoui/html
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants