-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds scrolling to Overwatch(OW) Consoles #8103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Quality of Life (one line change, one word addition) So much for that. No longer do you need to set your second monitor vertical to see the all the Squad, you can simply use the mouse wheel at your leisure.
Old Change: Although I've noticed (example on the screenshot below) that the CRT Effect only scales to the window size, not the contents but doesn't move with the scroll. Which uhh is a little noticeable.
Took more jiggling that I care to mention, but it mostly works. Window can be resized at least on my machine testing without too jarring of an effect. CRT Effect doesn't leave part way down, and of course the scroll works. And I moved it to just the Table of marines.
Additionally the changes I made pushed the Supply and OB sections to the bottom of the window so small change to them to not do that, I doubt many people will notice the difference.
Explain why it's good for the game
SOs without vertical monitors no longer need to be burning with jealousy of those that do and can see all the riflemen they don't really care about.
Testing Photographs and Procedure
Screenshots & Videos
Old Change
Current
Additional
Changelog
🆑 MistChristmas
qol: OW Consoles are scrollable
fix: Fixed eslint not checking jsx files
/:cl: