Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved some turf vars to turf flags #8100

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Conversation

blackcrystall
Copy link
Contributor

About the pull request

Added more things to turf_flags, see list in changelog, nothing how it's working changed, I just like bit operations

Changelog

🆑 BlackCrystalic
code: Moved vars as debrised, hull, burnable, burnt, breakable, broken to turf_flags as TURF_DEBRISED, TURF_HULL, TURF_BURNABLE, TURF_BURNT, TURF_BREAKABLE, TURF_BROKEN
/:cl:

@blackcrystall blackcrystall requested a review from fira as a code owner January 13, 2025 19:58
@cmss13-ci cmss13-ci bot added the Code Improvement Make the code longer label Jan 13, 2025
@cmss13-ci cmss13-ci bot added the Mapping did you remember to save in tgm format? label Jan 13, 2025
code/game/turfs/light.dm Outdated Show resolved Hide resolved
code/game/turfs/floor_types.dm Outdated Show resolved Hide resolved
code/game/turfs/floor_types.dm Outdated Show resolved Hide resolved
code/game/turfs/floor_types.dm Outdated Show resolved Hide resolved
@hry-gh
Copy link
Member

hry-gh commented Jan 23, 2025

i didn't get every instance but doing it that way is just more maintainable

@hry-gh hry-gh marked this pull request as draft January 23, 2025 11:08
@blackcrystall blackcrystall marked this pull request as ready for review January 23, 2025 12:11
@blackcrystall blackcrystall requested a review from hry-gh January 23, 2025 12:11
@hry-gh hry-gh added this pull request to the merge queue Jan 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 24, 2025
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jan 27, 2025
@Nanu308 Nanu308 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into cmss13-devs:master with commit 61ecfc5 Jan 27, 2025
29 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 27, 2025
@blackcrystall blackcrystall deleted the bruuuh branch January 27, 2025 17:44
BOBAMAx added a commit to BOBAMAx/cm that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants