Special Shrapnel fixes, Flaming shrapnel AP nerf. #8072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
Balance
| @@ -631,11 +631,11 @@ | |||
| // some upper limits | |||
| if(shards > max_ex_shards) | |||
| shards = max_ex_shards | |||
| if(istype(shard_type, /datum/ammo/bullet/shrapnel/incendiary) && shards > max_ex_shards / INCENDIARY_SHARDS_MAX_REDUCTION) // less max incendiary shards | |||
| if(ispath(shard_type, /datum/ammo/bullet/shrapnel/incendiary) && shards > max_ex_shards / INCENDIARY_SHARDS_MAX_REDUCTION) // less max incendiary shards | |||
There was a problem hiding this comment.
i think you can remove all of this and instead just add
max_ex_shards = max_exshards / INCENDIARY_SHARDS_MAX_REDUCTION
you can repeat that process in line 624 , 626 and 628 . so there is no need to check twice and its easier to read
Drulikar
approved these changes
Jan 18, 2025
Drulikar
reviewed
Jan 18, 2025
Drulikar
added
the
Balance Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
special shrapnel now use the correct check, meaning that max shrapnel is now properly reduced. Thanks to watermelon for noticing it and telling me how to fix it
In practice this means that flaming/neuro/hornets are now capped at 16 total (From 32).
AP from incind shrapnel reduced from 50 to 20
Explain why it's good for the game
Currently the incind shrapnel does 665 damage to a queen (before counting phosphor smoke)
Current Shrapnel Against Queen (Combat Ready/Mature)
Desktop.2025.01.09.-.23.54.36.96.mp4
This is enough damage to 1shot every single caste up to and including non-hedge ravs (both base and berz), as base has 650 health while berz has 590. Even having max rage, which brings you to 45(!!) armor, isn't enough to save you, as flaming shrapnel has 50 ap.
Against a berz rav on the frontline
gg.mp4
Shrapnel mines probably shouldn't have the killing power of pre nerf OT rockets?
Testing Photographs and Procedure
New Damage test against drone
It does around 460 damage total.PVP.CM.Testing.Drone.OT.Mine.460.damage.mp4
Changelog
🆑
balance: Flaming Shrapnel now has 20 AP (from 50)
fix: OT special shrapnel is now properly affected by the cap, meaning that you can only have 16 shrapnel (from 32)
/:cl: