fixes check status namecalling #8041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your author name should be after the 🆑, not in the text itself |
My bad |
harryob
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes #7530
This was because when it doing it's check, it is checking src, who is you. We want to check target.name, who is not us. Only when it is self (us), do we want it to refer to us as the target for that nuance.
Explain why it's good for the game
Bugfixman good
Testing Photographs and Procedure
There are a lot of checks for the status, so I admittedly did not go thru all of them, but when I manually deleted unknown's heart, it still was working as intended. I believe the rest works fine; since this only affects the [name] call during the Check Status proc, so it should have no effect on the rest of it.
Changelog
🆑 Yayyay007
fix: Fixes check status using your own name when using it on others
/:cl: