Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug where we forget to unregister signal #8029

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Jan 7, 2025

About the pull request

Bug, we don't remove signal in right moment, so just changed 4 lines of code for both CO guns

Changelog

no playeside facing changes

@cmss13-ci cmss13-ci bot added the Code Improvement Make the code longer label Jan 7, 2025
@kiVts
Copy link
Contributor

kiVts commented Jan 7, 2025

average player has no idea what you're trying to say in the changelog both due to poor English skills and too much depth on technical part, rewrite it.

@blackcrystall
Copy link
Contributor Author

blackcrystall commented Jan 7, 2025

Okay, better remove it at all, because really there no playerside affecting changes, just removed very old rare issue

@cmss13-ci cmss13-ci bot added the Missing Changelog Maintainers always document their changes. label Jan 7, 2025
@blackcrystall blackcrystall changed the title Maybe... or matybe not a feature Bug where we forget to unregister signal Jan 9, 2025
@harryob harryob added this pull request to the merge queue Jan 13, 2025
Merged via the queue into cmss13-devs:master with commit 7518571 Jan 13, 2025
37 checks passed
@blackcrystall blackcrystall deleted the GSDGGFVSGFAS branch January 20, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Missing Changelog Maintainers always document their changes.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants