Skip to content

Commit

Permalink
Minor Security Records computer fix. (#8417)
Browse files Browse the repository at this point in the history
# About the pull request
Fix allows you to print both records and fingerprint report.
Fix allows you to clear the fingerprint scanner #8404
Ejects the scanner to on top of the computer's turf instead of your
feet.
Adds some notice that it is printing.
Lowers the time it takes to print, in line with the photocopier.
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
Fix + QOL
I was also going to rename "Rank" to Position as the records don't show
ranks but positions, But Zolar has an open PR about sorting
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Printing security records + fingerprint report and clearing
qol: Adds a notice that they're printing. Moved the time it takes in
line with photocopier. And Fingerprint scanner ejects to the table
instead of your feet.
/:cl:
  • Loading branch information
MistChristmas authored Feb 10, 2025
1 parent 1eb12ee commit fd1b738
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions code/game/machinery/computer/security.dm
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
circuit = /obj/item/circuitboard/computer/secure_data
var/obj/item/card/id/scan = null
var/obj/item/device/clue_scanner/scanner = null
var/printing = null
var/printing = FALSE

/obj/structure/machinery/computer/secure_data/attackby(obj/item/O as obj, user as mob)

Expand Down Expand Up @@ -355,12 +355,11 @@
if (!scanner || !scanner.print_list)
to_chat(user, SPAN_WARNING("No scanner data found."))
return

sleep(50)
to_chat(user, SPAN_NOTICE("Printing report."))
sleep(15)
playsound(loc, 'sound/machines/twobeep.ogg', 15, 1)

var/obj/item/paper/fingerprint/P = new /obj/item/paper/fingerprint(src, scanner.print_list)
P.forceMove(loc)
var/obj/item/paper/fingerprint/P = new /obj/item/paper/fingerprint(loc, scanner.print_list)
var/refkey = ""
for(var/obj/effect/decal/prints/print in scanner.print_list)
refkey += print.criminal_name
Expand All @@ -372,6 +371,7 @@
to_chat(user, SPAN_WARNING("No scanner found."))
return

QDEL_NULL_LIST(scanner.print_list)
scanner.update_icon()
to_chat(user, SPAN_NOTICE("Fingerprints cleared from the scanner."))

Expand All @@ -381,7 +381,7 @@
return

scanner.update_icon()
scanner.forceMove(get_turf(user))
scanner.forceMove(get_turf(src))
scanner = null
if ("print_personal_record")
var/id = params["id"]
Expand All @@ -397,14 +397,13 @@
if (!general_record)
to_chat(user, SPAN_WARNING("Record not found."))
return

to_chat(user, SPAN_NOTICE("Printing record."))
sleep(15)
playsound(loc, 'sound/machines/print.ogg', 15, 1)
sleep(50)

var/obj/item/paper/personalrecord/P = new /obj/item/paper/personalrecord(user, general_record, security_record)
P.forceMove(loc)
var/obj/item/paper/personalrecord/P = new /obj/item/paper/personalrecord(loc, general_record, security_record)
P.name = text("Security Record ([])", general_record.fields["name"])
printing = null
printing = FALSE
if ("update_photo")
var/id = params["id"]
var/photo_profile = params["photo_profile"]
Expand Down

0 comments on commit fd1b738

Please sign in to comment.