Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VTK output #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add VTK output #2

wants to merge 4 commits into from

Conversation

philbucher
Copy link

Hi,
I found your project useful for some tests of mine, thanks for making it available!
Postprocessing with paraview is sth that I like to do, so I decided to implement it

Please let me know if this is a contribution you are interested in. I can of course also make it optional, via feature or input argument.

Attached is the example in vtk-files so that you can take a look
Thanks!
vtk_output.zip

@philbucher
Copy link
Author

@cmccomb

@cmccomb
Copy link
Owner

cmccomb commented Dec 23, 2024

Thanks for opening this PR @philbucher! I should be able to look into the failed check in the next few days but please feel free to act on it before I do.

What do you think about adding a test for VTK output? It would also be great to have a usage example for cookbook.rs and examples/!

@philbucher
Copy link
Author

I should be able to look into the failed check in the next few days but please feel free to act on it before I do.

I think the tokio::Runtime is outdated, does not seem to be related to my changes

What do you think about adding a test for VTK output? It would also be great to have a usage example for cookbook.rs and examples/!

sure that makes sense. I will have a look after the holidays. I can most probably also update the tokio failures, if you havent done it already

@cmccomb
Copy link
Owner

cmccomb commented Jan 2, 2025

Sorry to assume that the test fail had something to do with your PR! I fixed the tokio issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants