Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stormwind - add new script for Quest 'The Attack' #1244

Merged
merged 7 commits into from
Jan 25, 2025

Conversation

miraco
Copy link
Collaborator

@miraco miraco commented Jan 21, 2025

Previously there was a problem with royal guards attacking both Lord Gregor Lescovar and Marzon the Silent Blade making it hard to finish the quest.
Also add correct spawn points/waypoints + intro for Spybot
he spawns a little bit in the back from tyrion and moves to him



-- On Retail Tyrion only has the QuestGiver flag when the Spybot is staying next to him
UPDATE creature_template SET NpcFlags = 1 WHERE entry = 7766;
Copy link
Collaborator Author

@miraco miraco Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a bit risky and i think i'll out commit this before merging.
I can confirm that on retail Tyrion doesnt have the quest giver flag on spawn, he gets it after his spybot is back to him.

Will wait for @AnonXS opinion about this before merging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well I have seen quest flag even without the spybot near him, but I presume that was a glitch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two different snippets:

ServerToClient: SMSG_ON_MONSTER_MOVE (0x00DD) Length: 53 ConnIdx: 0 Time: 03/17/2009 01:06:26.000 Number: 98668
GUID: Full: 0xF130001E5611A8BD Type: Creature Entry: 7766 Low: 1157309
Facing Angle: 1.832596
Waypoint Endpoint: X: -8407.93 Y: 450.6629 Z: 123.8431

ServerToClient: SMSG_COMPRESSED_UPDATE_OBJECT (0x01F6) Length: 67 ConnIdx: 0 Time: 03/17/2009 01:06:26.000 Number: 98670
[1] UpdateType: Values
[1] GUID: Full: 0xF130001E5611A8BD Type: Creature Entry: 7766 Low: 1157309
[1] UNIT_NPC_EMOTESTATE: 69

ServerToClient: SMSG_COMPRESSED_UPDATE_OBJECT (0x01F6) Length: 708 ConnIdx: 0 Time: 03/17/2009 01:06:26.000 Number: 98675
[1] GUID: Full: 0xF130001E5611A8BD Type: Creature Entry: 7766 Low: 1157309
[1] UNIT_DYNAMIC_FLAGS: 0
[1] UNIT_NPC_FLAGS: 1
ServerToClient: SMSG_ON_MONSTER_MOVE (0x00DD) Length: 57 ConnIdx: 0 Time: 01/03/2009 17:04:28.000 Number: 92998
Position: X: -8407.93 Y: 450.6629 Z: 123.8431
Spline Type: 3 (FacingTarget)
Facing GUID: Full: 0xF13000229821FC71 Type: Creature Entry: 8856 Low: 2227313
Waypoint Endpoint: X: -8407.93 Y: 450.6629 Z: 123.8431

ServerToClient: SMSG_EMOTE (0x0103) Length: 12 ConnIdx: 0 Time: 01/03/2009 17:04:28.000 Number: 92999
Emote ID: 4 (OneShotCheer)
GUID: Full: 0xF130001E561E3AAE Type: Creature Entry: 7766 Low: 1981102

ServerToClient: SMSG_ON_MONSTER_MOVE (0x00DD) Length: 53 ConnIdx: 0 Time: 01/03/2009 17:04:32.000 Number: 93014
Position: X: -8407.93 Y: 450.6629 Z: 123.8431
Facing Angle: 0.05235988
Waypoint Endpoint: X: -8407.93 Y: 450.6629 Z: 123.8431

ServerToClient: SMSG_UPDATE_OBJECT (0x00A9) Length: 42 ConnIdx: 0 Time: 01/03/2009 17:04:32.000 Number: 93018
[0] GUID: Full: 0xF130001E561E3AAE Type: Creature Entry: 7766 Low: 1981102
[0] UNIT_NPC_FLAGS: 3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this part before pushing, it’s to risky to change it without having real evidence.

best way to check would be to kill the npc on classic and wait for respawn to see what flags he has on spawn

@al3xc1985
Copy link
Contributor

Previously there was a problem with royal guards attacking both Lord Gregor Lescovar and Marzon the Silent

As far as I remember those 2 guards should have a very low aggro range, I remember them attacking this 2 guys if someone would took them 2 close.

But I shall try to redo the q, tonight, and come back with info

@miraco
Copy link
Collaborator Author

miraco commented Jan 21, 2025

Yes those guards can aggro the 2 npcs, BUT when lord gregor lescovar enters the "garden" he tells the guards to leave him alone so he can meditate.
The waypoints from the guards are pretty far away from him (they move into the room where lescovar comes from) and stay there for 1 minute and 6 seconds.
This makes it rly unlikely that those guards enter combat with one of those 2 npcs.

Part of the quest is to kill those, this wasnt doable before those changes.
Also now we use completly sniff data for waypoints, spawns and timers. (Some were prob guess or just wrong before)

@al3xc1985
Copy link
Contributor

Sounds good

@miraco miraco merged commit eb6247c into cmangos:master Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants