#223 Gives venues readable slugs #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nelsonic
reviewed
Jan 9, 2019
| @@ -26,6 +26,7 @@ defmodule CsGuide.Resources.Venue do | |||
| field(:lat, :float) | |||
| field(:long, :float) | |||
| field(:distance, :float, virtual: true) | |||
| field(:slug, :string) | |||
There was a problem hiding this comment.
Worth having a re-useable :slug field dwyl/fields#31 ?
nelsonic
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
@Cleop work done for the client application looks good. 👍
Please consider doing the re-useable work up-front in dwyl/fields#31
such that the client application has fewer lines and is easier to maintain, and we get the benefit of reuse-ability for all future work. 💡
Thanks! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#223 Gives venues readable slugs consisting of the venue name and postcode, removes special characters, replaces spaces with dashes
script
add_venue_slug.exswill need running once deployed