#36 Creates search/drinks page #111
Conversation
|
|
||
| drinkDecoder : Decoder Drink | ||
| drinkDecoder = | ||
| Decode.map3 Drink |
There was a problem hiding this comment.
consider using decode pipeline in next iteration. https://github.com/NoRedInk/elm-json-decode-pipeline 👍
| schema "drink_types" do | ||
| field(:name, :string) | ||
| field(:entry_id, :string) | ||
| field(:deleted, :boolean) |
There was a problem hiding this comment.
alog should automatically add the :deleted column to any table where it is used.
see: dwyl/phoenix-ecto-append-only-log-example#7 (comment)
| join_keys: [drink_type_id: :id, drink_id: :id] | ||
| ) | ||
|
|
||
| timestamps() |
There was a problem hiding this comment.
we probably need to over-ride this phoenix macro as we don't need the updated_at column.
| }) | ||
| } | ||
|
|
||
| function swipe(el, callback){ |
There was a problem hiding this comment.
please add JSDOC comments to JavaScript code so others can understand it.
ideally state the source of the code.
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
please delete this file in the next iteration.
| field(:logo, :string) | ||
| field(:website, :string) | ||
| field(:entry_id, :string) | ||
| field(:deleted, :boolean, default: false) |
| @@ -0,0 +1,41 @@ | |||
| <%= form_for @changeset, @action, fn f -> %> | |||
There was a problem hiding this comment.
should this form be rendered by autoform ?
#36 Creates search/drinks page
#37 Enables filters on search/drinks page to filter by drink type