Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Dashboardの明示的なuid指定を削除 #1554

Merged
merged 5 commits into from
Feb 26, 2022
Merged

Conversation

iaoiui
Copy link
Contributor

@iaoiui iaoiui commented Feb 25, 2022

Description

uidが競合しているのが問題のため、ダッシュボードのjson内のuidを空にして適用することで、既存のダッシュボードと競合しないようにする。
uidはJSON内で任意に採番もできるが、一旦指定なしにすることでランダムなuidを振り直す

ランダムなuidを振り直した時の影響として、下記のようなDashboardのURLが変わるということ点があるが現状どこからもリンクされていないので影響なしと判断

https://grafana.dev.cloudnativedays.jp/d/MAc3Yf-nk/o11y2022dashboard?orgId=1

ref #1536

Type of change

  • Document update or simple typo fix
  • Maintenance/update components
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • I have checked backward/forward compatibility that may cause regarding this change.

@iaoiui iaoiui requested a review from oke-py February 25, 2022 14:51
@iaoiui iaoiui self-assigned this Feb 25, 2022
@iaoiui
Copy link
Contributor Author

iaoiui commented Feb 25, 2022

これで付加であれば一旦ダッシュボードをeditableにしてGUIから削除、もしくは空のjsonでダッシュボードをデプロイして競合状態を解決予定

Copy link
Member

@oke-py oke-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionの値を上げておきたいです。
uid変えたら1からでもいいかもしれませんが。

@iaoiui
Copy link
Contributor Author

iaoiui commented Feb 26, 2022

先にバージョンを8.4.xにあげるPRを別途作っておきますね

@oke-py
Copy link
Member

oke-py commented Feb 26, 2022

あ、JSONのuidの下のversionです。

dashboards/Contour-HTTProxy.json Outdated Show resolved Hide resolved
dashboards/Kubernetes-Pod.json Outdated Show resolved Hide resolved
dashboards/o11y2022-cfp.json Outdated Show resolved Hide resolved
dashboards/o11y2022-main.json Outdated Show resolved Hide resolved
@oke-py oke-py merged commit 7b7841c into main Feb 26, 2022
@oke-py oke-py deleted the grafana-uid-conflict branch February 26, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants