-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana Dashboardの明示的なuid指定を削除 #1554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
これで付加であれば一旦ダッシュボードをeditableにしてGUIから削除、もしくは空のjsonでダッシュボードをデプロイして競合状態を解決予定 |
oke-py
requested changes
Feb 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versionの値を上げておきたいです。
uid変えたら1からでもいいかもしれませんが。
先にバージョンを8.4.xにあげるPRを別途作っておきますね |
あ、JSONのuidの下のversionです。 |
oke-py
requested changes
Feb 26, 2022
Co-authored-by: Naoki Oketani <[email protected]>
Co-authored-by: Naoki Oketani <[email protected]>
Co-authored-by: Naoki Oketani <[email protected]>
Co-authored-by: Naoki Oketani <[email protected]>
oke-py
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
uidが競合しているのが問題のため、ダッシュボードのjson内のuidを空にして適用することで、既存のダッシュボードと競合しないようにする。
uidはJSON内で任意に採番もできるが、一旦指定なしにすることでランダムなuidを振り直す
ランダムなuidを振り直した時の影響として、下記のようなDashboardのURLが変わるということ点があるが現状どこからもリンクされていないので影響なしと判断
ref #1536
Type of change
How Has This Been Tested?