fix: use consistent namespace templating #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwdmr
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
itay-grudev
as code owners
Replace all instances of .Release.Namespace with include "cloudnative-pg.namespace" helper to ensure consistent namespace handling throughout the chart. chart cloudnative-pg: - Deployment WATCH_NAMESPACE environment variable - Webhook service namespace references - RBAC subject namespace references - Installation notes and examples chart cluster: - Job Server Ping namespace reference This change ensures the chart properly respects namespaceOverride in all components. Signed-off-by: bwdmr <[email protected]>
itay-grudev
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all instances of .Release.Namespace with include "cloudnative-pg.namespace" helper to ensure consistent namespace handling throughout the chart.
This change ensures the chart properly respects namespaceOverride in all components.