fix(cluster): correct CNPGClusterOffline rule description #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to patch these files as well, for consistency? |
|
Both Do you want me to modify them anyways to make it consistent with the others? |
mymasse
force-pushed
the
main
branch
2 times, most recently
from
5e3e9d0 to
b80e29f
Compare
Use `namespace/cluster` instead of `labels.job` which is not returned in the expression. Fixes: cloudnative-pg#428 Signed-off-by: Mathieu Masse <[email protected]>
|
@mymasse No. It's fine. Thank you very much. |
itay-grudev
approved these changes
Nov 7, 2024
yremmet
pushed a commit
to yremmet/charts
that referenced
this pull request
Dec 9, 2024
…e-pg#429) Use `namespace/cluster` instead of `labels.job` which is not returned in the expression. Fixes: cloudnative-pg#428 Signed-off-by: Mathieu Masse <[email protected]>
hapeho
pushed a commit
to hapeho/cloudnative-pg-charts
that referenced
this pull request
Dec 18, 2024
…e-pg#429) Use `namespace/cluster` instead of `labels.job` which is not returned in the expression. Fixes: cloudnative-pg#428 Signed-off-by: Mathieu Masse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
namespace/clusterinstead oflabels.jobwhich is not returned in the expression.Fixes: #428