add PGDBNAME to database-ping-test #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UgurcanAkkok
changed the title
phisco
reviewed
Sep 6, 2024
Signed-off-by: Uğurcan Akkök <[email protected]>
Signed-off-by: Uğurcan Akkök <[email protected]>
itay-grudev
approved these changes
Dec 7, 2024
yremmet
pushed a commit
to yremmet/charts
that referenced
this pull request
Dec 9, 2024
* add PGDBNAME to database-ping-test cloudnative-pg#368 Signed-off-by: Uğurcan Akkök <[email protected]> * fix(cluster): make PGDBNAME optional in ping.yaml cloudnative-pg#368 Signed-off-by: Uğurcan Akkök <[email protected]> --------- Signed-off-by: Uğurcan Akkök <[email protected]> Co-authored-by: Itay Grudev <[email protected]>
hapeho
pushed a commit
to hapeho/cloudnative-pg-charts
that referenced
this pull request
Dec 18, 2024
* add PGDBNAME to database-ping-test cloudnative-pg#368 Signed-off-by: Uğurcan Akkök <[email protected]> * fix(cluster): make PGDBNAME optional in ping.yaml cloudnative-pg#368 Signed-off-by: Uğurcan Akkök <[email protected]> --------- Signed-off-by: Uğurcan Akkök <[email protected]> Co-authored-by: Itay Grudev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #368 by adding
$PGDBNAMEenv var to database-ping-test.Note that if the user uses a custom secret in the initdb, they will also need to add the dbname to the secret.
I am happy to help in case of any missing changes for the fix.