Create serviceBinding.io secret with type app only

[ddraganovv]

Is there a related GitHub Issue?

GitHub Issue

What is this change about?

When the type of the credential binding is 'key' creating a servicebinding.io secret is redundant. This PR's goal is changing the way the controller creates sbio secrets so it is only created when the type is 'app'

Does this PR introduce a breaking change?

No

Acceptance Steps

The servicebinding.io secret should not be created when the type of the credential binding is 'app'

[danail-branekov]

I would suggest renaming createdSecret to credentialsSecret as the secret here stores the credentials for the binding. This name would convey what that secret is (improves readability)

I would also change the way the secret is being looked up to be align with the way we lookup objects:

credentialsSecret := &corev1.Secret{
	ObjectMeta: metav1.ObjectMeta{
			Name:      cfServiceBinding.Name,
			Namespace: cfServiceBinding.Namespace,
		},
}
if err := r.k8sClient.Get(ctx, client.ObjectKeyFromObject(credentialsSecret), credentialsSecret); err != nil {
	return nil, err
}