Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not create service binding io secret for key bindings #3739

Open
Tracked by #2320
danail-branekov opened this issue Jan 21, 2025 · 0 comments
Open
Tracked by #2320

do not create service binding io secret for key bindings #3739

danail-branekov opened this issue Jan 21, 2025 · 0 comments
Labels
bug Something isn't working managed-services

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Jan 21, 2025

We are currently creating a service binding io secret for bindings of type key. For such bindings we do not create servicebindingio binding, therefore this secret is not used. We should therefore:

  • not create the secret
  • do not set the CFServiceBinding.Status.Binding.Name field
  • Verify usages of CFServiceBinding.Status.Binding.Name (probaly none, as this is the sbio "ducktype" and should be not referenced by Korifi code at all) - would an empty value be an issue?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working managed-services
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

1 participant