Fix Docker workflow #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Thanks for fixing it. Side comment: yaml also provide a line folding syntax, which would allow you to not |
thibmeu
approved these changes
May 15, 2024
thibmeu
reviewed
May 15, 2024
cjpatton
reviewed
May 15, 2024
There was a problem hiding this comment.
LGTM. @tgeoghegan please squash and I'll approve and merge.
The `docker.yml` GitHub Actions workflow was using the wrong syntax for a YAML multiline string, causing it to fail as in [1]. The `docker run` invocation was also incorrect. [1]: https://github.com/cloudflare/privacy-gateway-server-go/actions/runs/9097813677
tgeoghegan
force-pushed
the
fix-docker-action
branch
from
883815b to
6062433
Compare
|
@cjpatton squashed, thank you for your review. |
cjpatton
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker.ymlGitHub Actions workflow was using the wrong syntax for a YAML multiline string, causing it to fail as in 1.