Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pine: Optimizations #651

Merged
merged 2 commits into from
Aug 23, 2024
Merged

pine: Optimizations #651

merged 2 commits into from
Aug 23, 2024

Conversation

cjpatton
Copy link
Contributor

@cjpatton cjpatton commented Aug 15, 2024

Partially addresses #618.
Based on #649 (merge that first).

This PR implements the following optimizations for PINE:
junyechen1996/draft-chen-cfrg-vdaf-pine#96
junyechen1996/draft-chen-cfrg-vdaf-pine#97

@cjpatton cjpatton force-pushed the cjpatton/618/9-optimizations branch from ee27e21 to 2b1997d Compare August 22, 2024 18:54
@cjpatton cjpatton marked this pull request as ready for review August 22, 2024 18:55
@cjpatton cjpatton changed the title PINE optimizations pine: Optimizations Aug 22, 2024
Base automatically changed from cjpatton/618/8-one-norm-equality-check to main August 22, 2024 21:54
We are aiming for dimension of 200k. Also, rough-tune the chunk length
for the circuits.
@cjpatton cjpatton force-pushed the cjpatton/618/9-optimizations branch from 2b1997d to 96914e6 Compare August 22, 2024 21:55
crates/daphne/src/pine/flp.rs Outdated Show resolved Hide resolved
crates/daphne/src/pine/flp.rs Outdated Show resolved Hide resolved
@cjpatton cjpatton force-pushed the cjpatton/618/9-optimizations branch from 8ab98b7 to 6e5f9b5 Compare August 22, 2024 22:48
@cjpatton cjpatton requested a review from armfazh August 22, 2024 23:48
Copy link
Contributor

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit, but other than that it looks good.

Implement the following changes to the PINE specification:

junyechen1996/draft-chen-cfrg-vdaf-pine#96 -
Reduce the amount of bit twiddling required for running the wraparound
tests.

junyechen1996/draft-chen-cfrg-vdaf-pine#97 - For
the squared norm equality check, use a squaring gadget rather than a
multiplication gadget.
@cjpatton cjpatton force-pushed the cjpatton/618/9-optimizations branch from 7698510 to 31fb607 Compare August 23, 2024 18:08
@cjpatton cjpatton merged commit b17fa36 into main Aug 23, 2024
3 checks passed
@cjpatton cjpatton deleted the cjpatton/618/9-optimizations branch August 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants