Make abort->error conversion one way #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
cjpatton
as code owners
mendess
force-pushed
the
mendess/simplify-error-conversions
branch
from
ac494d0 to
df1047c
Compare
mendess
force-pushed
the
mendess/simplify-error-conversions
branch
from
df1047c to
4f2f054
Compare
Having DapError convertible into DapAbort means that an Error can be converted into an abort and an abort converted into an error an infinite number of times, meaning the type can grow in an unbounded way at runtime. This is very confusing to reason about when reading the signature of a method that returns a `DapAbort`. Now a method that returns a `DapAbort` can only return due to a documented protocol error and not another system related error (such as mis configuration or IO).
mendess
force-pushed
the
mendess/simplify-error-conversions
branch
from
4f2f054 to
8fd75a3
Compare
cjpatton
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having DapError convertible into DapAbort means that an Error can be
converted into an abort and an abort converted into an error an infinite
number of times, meaning the type can grow in an unbounded way at
runtime. This is very confusing to reason about when reading the
signature of a method that returns a
DapAbort. Now a method thatreturns a
DapAbortcan only return due to a documented protocol errorand not another system related error (such as mis configuration or IO).
This PR removes the
impl From<DapError> for DapAbortimplementation and fixesthe code accordingly.