Fix out share -> agg share hack in AggregateStore

cloudflare · Dec 1, 2023 · b97bbb8 · b97bbb8
1 parent 46d7919
commit b97bbb8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -32,7 +32,7 @@ hpke-rs-crypto = "=0.1.1"
 hpke-rs-rust-crypto = "=0.1.1"
 matchit = "0.7.3"
 paste = "1.0.14"
-prio = { git = "https://github.com/divviup/libprio-rs", rev = "4ca547f35ebedf36fce45108ff8a29e14d51d048" }
+prio = { git = "https://github.com/divviup/libprio-rs", rev = "f067f384df127bdbd5e35116bbf437e765238eb2" }
 prometheus = "0.13.3"
 rand = "0.8.5"
 rand_core = "0.6.4"

diff --git a/daphne_worker/src/durable/aggregate_store.rs b/daphne_worker/src/durable/aggregate_store.rs
@@ -16,7 +16,7 @@ use daphne::{
 use prio::{
     codec::{Decode, Encode},
     field::FieldElement,
-    vdaf::{AggregateShare, OutputShare},
+    vdaf::AggregateShare,
 };
 use serde::{de::DeserializeOwned, Deserialize, Serialize};
 use tracing::Instrument;
@@ -190,8 +190,7 @@ impl AggregateStore {
                             .expect("string never fails to convert to JsValue"),
                     )
                 })?;
-                // TODO(mendess): this an abuse of this API, this type should not be constructed this way.
-                Ok(AggregateShare::from(OutputShare::from(share)))
+                Ok(AggregateShare::from(share))
             }
 
             let data = match kind {