[Ruleset Engine] Review examples for request body fields #19118
Merged
+181
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cloudflare-docs with
|
| Latest commit: |
ac190f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://087b9ecb.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://pedro-2025-01-10-ruleset-eng.cloudflare-docs-7ou.pages.dev |
pedrosousa
changed the title
pedrosousa
commented
Jan 10, 2025
| @@ -72,15 +72,14 @@ The return value may be truncated if [`http.request.body.truncated`](#httpreques | |||
| - **Whitespace:** preserved | |||
| - **Non-ASCII:** preserved | |||
|
|
|||
| Example: | |||
There was a problem hiding this comment.
Moved below the example value.
pedrosousa
commented
Jan 10, 2025
| @@ -203,7 +210,11 @@ List of `Content-Disposition` headers for each part in the multipart body. | |||
|
|
|||
| Example value: | |||
|
|
|||
| `[["form-data; name=\"username\"], ["form-data;name=\"picture\"]]` | |||
| `[["form-data; name=\"username\""], ["form-data; name=\"picture\""]]` | |||
There was a problem hiding this comment.
Fixed example value (missing double quotes).
pedrosousa
commented
Jan 10, 2025
src/content/docs/ruleset-engine/rules-language/fields/http-request-body.mdx
Outdated
Show resolved
Hide resolved
Maddy-Cloudflare
approved these changes
Jan 10, 2025
pedrosousa
deleted the
pedro/2025-01-10-ruleset-engine-add-content-disposition-expression-example
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reported via internal chat.
Also changes "Example:" to "Example usage:" to better distinguish these examples from example values.