LITE-29452 Fix dictonary change error #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzevaka
suggested changes
Feb 19, 2024
| @@ -30,7 +31,7 @@ def get_method_name(self, task_data, argument): | |||
| return self.handler.events[task_data.input.event_type]['method'] | |||
|
|
|||
| async def get_argument(self, task_data): | |||
| return task_data.input.data | |||
| return copy.copy(task_data.input.data) | |||
There was a problem hiding this comment.
[SOL-A] copy.copy does a shallow copy. This approach will not fix the problem in the case of deep objects.
It looks like deepcopy is more appropriate here.
There was a problem hiding this comment.
[COD-B] Let's cover this with tests
bdjilka
force-pushed
the
bugfix/LITE-29452-dictionary-changed-error
branch
from
7d4a125 to
0c2c65b
Compare
zzzevaka
approved these changes
Feb 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.