LITE-29279: Add new components #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create SimpleDialog component - Create FormDialog component - Create RadioTable component - Create RadioInput component - Create SelectInput component - Create TextField component (wraps Connect UI Toolkit textfield) - Create VerticalTabs component - Create webComponents utils - Create validation utils - Create generic utils - Update MainPage component to listen to "fullscreenSize" event from the Connect Portal - Update views to inherit height styles - Added more colors to COLORS_DICT constant
- Move all tests to /ui/tests directory - Create "createFactory" function to ease testing Vue components - Refactor confusing usages of vi.doMock for regular vi.mock
| import { mount, shallowMount } from '@vue/test-utils'; | ||
| import merge from 'lodash.merge'; | ||
|
|
||
| export const createFactory = |
There was a problem hiding this comment.
what would be the goal of this factory?, it is mounting and setting options
There was a problem hiding this comment.
It's a way to simplify component setup. When you need to set up lots of properties for a component, like in the FormDialog test, you need to repeat that in each point where you mount the component, which is very painful.
This is a pattern that I've used in the past with Vue Test Utils, it works quite well for medium-to-large components, or just small components that need lots of stubs.
I am not sure if this is the best option to use as a standard for our extension tests, but I'd keep it for now since it solves an issue, and we can figure out if we like it or not during development. Wdyt?
nerimartinez
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty big PR to add new components, mainly
SimpleDialogandFormDialog.SimpleDialogcomponentFormDialogcomponentRadioTablecomponentRadioInputcomponentSelectInputcomponentTextFieldcomponent (wraps Connect UI Toolkit textfield)VerticalTabscomponentwebComponentsutilsvalidationutilsMainPagecomponent to listen to the"fullscreenSize"event from the Connect PortalCOLORS_DICTconstant