Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LITE-29258 Setup repo #1

Merged
merged 1 commit into from
Jan 3, 2024
Merged

LITE-29258 Setup repo #1

merged 1 commit into from
Jan 3, 2024

Conversation

jonatrios
Copy link
Contributor

No description provided.

@jonatrios jonatrios self-assigned this Jan 3, 2024
akodelia
akodelia previously approved these changes Jan 3, 2024
maxipavlovic
maxipavlovic previously approved these changes Jan 3, 2024
Copy link
Member

@maxipavlovic maxipavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM

Dockerfile Outdated
@@ -0,0 +1,9 @@
FROM cloudblueconnect/connect-extension-runner:27.25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about the connect-extension-runner version? Seems a bit outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

name: Backend tests
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need only one 3.10 version :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@jonatrios jonatrios dismissed stale reviews from maxipavlovic and akodelia via 8c03a8f January 3, 2024 17:05
@jonatrios jonatrios force-pushed the LITE-29258-setup-repo branch from e3c9dc9 to 8c03a8f Compare January 3, 2024 17:05
@maxipavlovic maxipavlovic merged commit 8399349 into master Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants