Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace gpg #63

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Whitespace gpg #63

merged 1 commit into from
Feb 2, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Feb 2, 2024

Changes proposed in this pull request:

  • Whitespace change to create commit signed by new gpg key

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@cweibel cweibel requested a review from a team February 2, 2024 18:04
@cweibel cweibel merged commit e5c82d4 into main Feb 2, 2024
1 of 2 checks passed
@cweibel cweibel deleted the gpg branch February 2, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants