Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics-server panels for monitoring stack ... #121

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

afcollins
Copy link
Member

... also resizes some other panels that were aggregiously large

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This commit adds resource usage panels for metrics-server, which is an important part of the monitoring stack, to the monitoring panel.

Also, legends no longer sort by 'Max' due to a capitalization change.

And, this makes some panels smaller that were unnecessarily large for how important they are.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

I ran make v2 locally and overwrote the dashboards on a freshly deployed dittybopper.

... also resizes some other panels that were aggregiously large
@afcollins
Copy link
Member Author

Screenshots of the changes below:

Screenshot 2024-07-11 at 14 26 58 Screenshot 2024-07-11 at 14 27 06 Screenshot 2024-07-11 at 14 28 30

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@afcollins afcollins merged commit fd68ef1 into master Jul 15, 2024
2 checks passed
@afcollins afcollins deleted the metrics-server-panels branch July 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants