Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Kube-burner report mode Dashboard #120

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Adding Kube-burner report mode Dashboard #120

merged 3 commits into from
Jul 24, 2024

Conversation

smandaRH
Copy link
Collaborator

@smandaRH smandaRH commented Jul 8, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding Kube-burner report mode Dashboard to grafonnet.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@smandaRH smandaRH requested review from jtaleric and vishnuchalla July 8, 2024 06:28
@smandaRH
Copy link
Collaborator Author

smandaRH commented Jul 8, 2024 •
edited
Loading

Old dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/D5E8c5XVz/kube-burner-report-mode?orgId=1&var-Datasource=ab3f14e6-a50f-4d52-93fa-a5076794f864&var-platform=AWS&var-sdn=OVNKubernetes&var-clusterType=rosa&var-benchmark=node-density&var-workerNodesCount=24&var-ocpMajorVersion=4.14&var-ocpMajorVersion=4.15&var-uuid=2567763c-8f69-4cd0-8358-f5274ae8323c&var-uuid=2b3c5a16-1cac-455b-831e-b897f34032a8&var-uuid=372a2717-7708-4502-bbee-a7b19bc3c955&var-uuid=45b65e67-f7b8-4c85-bb50-ee3ec79b0916&var-uuid=645cdfc2-b649-474a-9ac0-5931b7d5f5c1&var-uuid=6a08a647-ea94-4230-8402-4822446337bc&var-uuid=7fdf7cea-0db8-4276-8e8c-a0e231fa6a06&var-uuid=813568fa-09e1-4dce-a8a4-e98f3be793f0&var-uuid=873bb1de-857d-4724-9211-a803476317c5&var-uuid=8c9c1e2c-237b-43fb-a5e7-036810f9c8a6&var-uuid=bbc6fece-47c8-40bf-a05e-5ba856949a24&var-uuid=c173725e-d8c8-44cb-a35d-ce86f81a7892&var-compare_by=metadata.ocpMajorVersion&var-component=kube-apiserver&var-component=kube-controller-manager&var-node_roles=masters&var-node_roles=workers&var-node_roles=infra&from=now-30d&to=now&tab=query

Jsonnet new dashboard: https://grafana.rdu2.scalelab.redhat.com:3000/d/bf427570-4f74-4846-9bf5-233a995119e5/kube-burner-report-mode-dashboard-smanda-copy?orgId=1&var-Datasource=ab3f14e6-a50f-4d52-93fa-a5076794f864&var-platform=AWS&var-sdn=OVNKubernetes&var-clusterType=rosa&var-benchmark=node-density&var-workerNodesCount=24&var-masterNodesType=All&var-uuid=2567763c-8f69-4cd0-8358-f5274ae8323c&var-uuid=2b3c5a16-1cac-455b-831e-b897f34032a8&var-uuid=372a2717-7708-4502-bbee-a7b19bc3c955&var-uuid=45b65e67-f7b8-4c85-bb50-ee3ec79b0916&var-uuid=645cdfc2-b649-474a-9ac0-5931b7d5f5c1&var-uuid=6a08a647-ea94-4230-8402-4822446337bc&var-uuid=7fdf7cea-0db8-4276-8e8c-a0e231fa6a06&var-uuid=813568fa-09e1-4dce-a8a4-e98f3be793f0&var-uuid=873bb1de-857d-4724-9211-a803476317c5&var-uuid=8c9c1e2c-237b-43fb-a5e7-036810f9c8a6&var-uuid=bbc6fece-47c8-40bf-a05e-5ba856949a24&var-uuid=c173725e-d8c8-44cb-a35d-ce86f81a7892&var-compare_by=metadata.ocpMajorVersion&var-component=kube-apiserver&var-component=kube-controller-manager&var-node_roles=masters&var-node_roles=workers&var-node_roles=infra&from=now-30d&to=now&var-ocpMajorVersion=4.14&var-ocpMajorVersion=4.15&chunkNotFound&tab=query

@smandaRH smandaRH self-assigned this Jul 8, 2024
@smandaRH smandaRH added the enhancement New feature or request label Jul 8, 2024
vishnuchalla
vishnuchalla reviewed Jul 12, 2024
View reviewed changes
templates/CPT/kube-burner-report-mode-v2.jsonnet
panels.barChart.ReadOnlyAPIrequestP99latency('Mutating API request P99 latency', 's', queries.MutatingAPIrequestP99Latency.query(), { x: 0, y: 32, w: 12, h: 6 }),
panels.barChart.ReadOnlyAPIrequestP99latency('Maximum Mutating API request P99 latency', 's', queries.MaxMutatingAPIrequestP99Latency.query(), { x: 12, y: 32, w: 12, h: 6 }),
]),
g.panel.row.new('ETCD')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit-pick] This used to be Etcd.

vishnuchalla
vishnuchalla approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough and nice work. Requesting @rook to take an another look.

@rsevilla87 rsevilla87 self-requested a review July 24, 2024 13:25
@vishnuchalla vishnuchalla merged commit efabd4c into cloud-bulldozer:master Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@jtaleric jtaleric Awaiting requested review from jtaleric

@rsevilla87 rsevilla87 Awaiting requested review from rsevilla87

Assignees

@smandaRH smandaRH

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smandaRH @vishnuchalla @rsevilla87