Adding Cilium K8s Performance Dashboard to grafonnet #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smandaRH
requested review from
jtaleric,
rsevilla87,
krishvoor and
vishnuchalla
jtaleric
reviewed
Dec 19, 2023
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
i will update it .
jtaleric
reviewed
Dec 19, 2023
|
|
||
| ciliumContainerCPU: { | ||
| query(): | ||
| prometheus.withExpr('sum(irate(container_cpu_usage_seconds_total{container=~\"cilium.*\",container!=\"cilium-operator.*\",namespace!=\"\"}[$interval])) by (instance,pod,container,namespace,name,service) * 100') |
There was a problem hiding this comment.
why all these expressions? just pull all the containers in namespace=cilium
jtaleric
reviewed
Dec 19, 2023
|
|
||
| ciliumConatinerMemory: { | ||
| query(): | ||
| prometheus.withExpr('container_memory_rss{container=~\"cilium.*\",namespace!=\"\"}') |
There was a problem hiding this comment.
Same comment as above, just look at the namespace
There was a problem hiding this comment.
sure , i will do that.
vishnuchalla
requested changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adding Cilium K8S Performance Dashboard to Grafonnet.
Related Tickets & Documents
Checklist before requesting a review
Testing