Skip to content

Commit

Permalink
assistant: Remove feature flag for terminal inline assistant (zed-ind…
Browse files Browse the repository at this point in the history
…ustries#15432)

This PR removes the feature flag for the terminal inline assistant,
making it available to everyone.

Release Notes:

- Use Ctrl+Enter to summon the inline assistant in the terminal, which
let's you generate terminal commands based on your description
([demo](https://twitter.com/thorstenball/status/1814241447383605329))
  • Loading branch information
bennetbo authored Jul 29, 2024
1 parent f124ca6 commit 0b4afe5
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 12 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/assistant/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ collections.workspace = true
command_palette_hooks.workspace = true
completion.workspace = true
editor.workspace = true
feature_flags.workspace = true
fs.workspace = true
futures.workspace = true
fuzzy.workspace = true
Expand Down
5 changes: 0 additions & 5 deletions crates/assistant/src/assistant_panel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -644,11 +644,6 @@ impl AssistantPanel {
.focus_handle(cx)
.contains_focused(cx)
{
use feature_flags::FeatureFlagAppExt;
if !cx.has_flag::<feature_flags::TerminalInlineAssist>() {
return None;
}

if let Some(terminal_view) = terminal_panel
.read(cx)
.pane()
Expand Down
5 changes: 0 additions & 5 deletions crates/feature_flags/src/feature_flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ impl FeatureFlag for LanguageModels {
const NAME: &'static str = "language-models";
}

pub struct TerminalInlineAssist {}
impl FeatureFlag for TerminalInlineAssist {
const NAME: &'static str = "terminal-inline-assist";
}

pub struct GroupedDiagnostics {}
impl FeatureFlag for GroupedDiagnostics {
const NAME: &'static str = "grouped-diagnostics";
Expand Down

0 comments on commit 0b4afe5

Please sign in to comment.