Change conda and pip dependency handling #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clbarnes
reviewed
Nov 13, 2019
|
I updated the PR according to our discussion and checked the conda build locally. |
|
Travis looks good, all conda packages except of nifty (which is a separate issue) are found and installed properly. @clbarnes if you go ahead and merge this, we can finish the main PR :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to handle conda only and pip only dependencies, see also constantinpape#2.
This solution misuses the
extra_requirementsa bit, but this would be fine with me.I have already tested the build in conda and this seems to work.
Whoever installs this with setuptools now can only use the
"pip"extra requirements.