Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back default land bounds #275

Merged
merged 3 commits into from
Dec 16, 2017
Merged

Conversation

mandli
Copy link
Member

@mandli mandli commented Jun 27, 2017

In some instances the land bounds were not being set making the land plotting janky (technical term for awful).

@mandli
Copy link
Member Author

mandli commented Jun 27, 2017

Something is wrong with the colorbars that I need to fix (they are off center). Looking into it.

@mandli
Copy link
Member Author

mandli commented Jun 29, 2017

@rjleveque are you seeing this in any other examples? I am somewhat suspicious that this might be related to the pobj issue (clawpack/visclaw#219). Note that I am seeing this in both 2.7 and 3.x but for matplotlib version 2.0.x.

figure_1003

@mandli
Copy link
Member Author

mandli commented Jun 29, 2017

One thing to note here is that in this particular example I try to set the colorbar ticks manually. Not doing this does not fix the problem but makes it mildly better.

@rjleveque
Copy link
Member

@mandli: Do you mean the fact that colorbar colors aren't centered about 0? But it looks like the ocean is white indicating no disturbance at some negative elevation. Maybe you have sea_level set to something other than 0 and the setplot is set to center around that value (I do this for some situations).

@mandli
Copy link
Member Author

mandli commented Jun 29, 2017

I think I figured out the problem. For the Ike example sea_level != 0.0 but in matplotlib version < 2 I translated the colorbar so that it looked like sea_level was the zero point but plotted as zero. It appears that the colorbar now always takes the vmin and vmax from the pobj rather than respecting clim. I am not sure if this is completely true but testing seems to indicate this to be the case.

So it's not probably related to clawpack/visclaw#219 but another fix for the plotting needs to be made. New commit forthcoming.

@mandli
Copy link
Member Author

mandli commented Jul 2, 2017

This is now working in Python2 but Python3 has the problem in clawpack/visclaw#219 as described. The fix there seems to work for Python2 and Python3.

@mandli mandli merged commit a8c7a28 into clawpack:master Dec 16, 2017
@mandli mandli deleted the add-land-bounds branch February 12, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants