Avoid warnings instead of hiding them #2873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleinreact
force-pushed
the
avoid-warnings
branch
from
49b4972 to
8d9e931
Compare
kleinreact
force-pushed
the
avoid-warnings
branch
from
8d9e931 to
c5bc2dd
Compare
kleinreact
force-pushed
the
avoid-warnings
branch
from
c5bc2dd to
afee508
Compare
kleinreact
force-pushed
the
avoid-warnings
branch
from
afee508 to
c1c1517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain GHC warnings are currently disabled in in
Clash.Preludeto hide the fact some imports and bindings are not used, and that some of the patterns inClash.Sized.Vectorare incomplete. As this is avoidable though, and having those flags enabled may also hide problems that are easy to catch otherwise. Therefore, this PR just avoids production of the respective warnings in the first place.The only current exception is
Clash.Tutorial, where the unused imports are used to have shorter Haddock references. We also can avoid that one by using fully qualified imports for the references instead. I'm in favor of introducing those changes as part of this PR too, but please let me know first, whether that's of common interest, as it takes a few minutes to apply all the changes along the file.Requires (parts of)
Still TODO:
Write a changelog entry (see changelog/README.md)