Make aws-sdk a peer dependency #162
Conversation
Much like joi, aws-sdk is often required by both the library and the consumer so it also makes sense to be a peer dependency as well.
|
Let's do it 👍 |
|
What's the hold up? |
package.json
Outdated
| @@ -45,6 +45,7 @@ | |||
| "sinon": "4.0.1" | |||
| }, | |||
| "peerDependencies": { | |||
| "aws-sdk": "2.131.0", | |||
There was a problem hiding this comment.
I agree, but it was pinned before so I kept it the same.
There was a problem hiding this comment.
I would strongly recommending changing it. Dependency pinning makes perfect sense, however it doesn't make sense for peer dependencies (especially not for a fast changing one like aws sdk). It defeats the purpose plus this dependency has a known vulnerability.
There was a problem hiding this comment.
Ahhh ok great point. I'll change it.
|
Why hasn't this been merged yet? |
|
I can merge it but I'm not sure what good it would do; @clarkie doesn't seem to be around anymore and I don't have the ability to push releases to npm. |
|
@cdhowie maybe it's time to fork and publish under a different package name? |
|
Having said that... I'm in the process of writing my own orm. So I'm don't really care about this project much anymore (sorry). |
Much like joi, aws-sdk is often required by both the library and the
consumer so it also makes sense to be a peer dependency as well.