Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github workflows for building and publishing #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add github workflows for building and publishing #9

wants to merge 2 commits into from

Conversation

Stupremee
Copy link
Member

Pull Request Template

Checklist

  • There is an existing issue report for this PR.
  • I have forked this project.
  • I have created a feature branch.
  • My changes have been committed.
  • I have pushed my changes to the branch.

Title

Github Actions

Description

This Pull Request adds workflow configurations for building and publishing clamor.

New or Changed Features

  • Add workflow to build clamor
  • Add workflow to publish clamor on release

vbe0201
vbe0201 reviewed Nov 23, 2019
View reviewed changes
Copy link
Member

@vbe0201 vbe0201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, apart from a single spelling mistake. And you could also delete the .travis.yml as it won't be needed anymore when this is merged.

.github/workflows/publish.yml Outdated
@@ -0,0 +1,16 @@
name: Publish clamor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clamor should be capitalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbe0201 vbe0201 vbe0201 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stupremee @vbe0201