Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script for automated tests in ckeditor5-dev-tests package does not exclude ignored paths on Windows #17797

Closed
psmyrek opened this issue Jan 22, 2025 · 0 comments · Fixed by ckeditor/ckeditor5-dev#1062
Closed

Script for automated tests in ckeditor5-dev-tests package does not exclude ignored paths on Windows #17797

psmyrek opened this issue Jan 22, 2025 · 0 comments · Fixed by ckeditor/ckeditor5-dev#1062
Assignees
@martnpaneq
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 83

Comments

@psmyrek
Copy link
Contributor

psmyrek commented Jan 22, 2025 •
edited by pomek
Loading

📝 Provide detailed reproduction steps (if any)

  1. On Windows, execute yarn run test -f enter.
  2. Check the generated entry file: build/.automated-tests/entry-point.js.

✔️ Expected result

There should be no ignored paths.

❌ Actual result

The entry point file contains ignored paths to manual tests:

...
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/utils.js";
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/shiftentercommand.js";
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/shiftenter.js";
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/shiftenter-integration.js";
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/enterobserver.js";
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/entercommand.js";
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/enter.js";
import "D:/Projects/ckeditor/ckeditor5/packages/ckeditor5-enter/tests/manual/enter.js"; // This one is invalid.
...

❓ Possible solution

The minimatch package requires using forward-slashes in glob expressions.

See https://github.com/ckeditor/ckeditor5-dev/blob/a4da6c2f147e3b895473233cf4ef61d1da173075/packages/ckeditor5-dev-tests/lib/tasks/runautomatedtests.js#L88.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@psmyrek psmyrek added package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior. labels Jan 22, 2025
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jan 22, 2025
@martnpaneq martnpaneq self-assigned this Jan 23, 2025
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jan 23, 2025
@martnpaneq martnpaneq mentioned this issue Jan 29, 2025
Merged
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 31, 2025
@CKEditorBot CKEditorBot added this to the iteration 83 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martnpaneq martnpaneq

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 83
Development

Successfully merging a pull request may close this issue.

Fixed automated tests entry point on Windows. ckeditor/ckeditor5-dev
3 participants
@CKEditorBot @psmyrek @martnpaneq