-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed automated tests entry point on Windows. #1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but now we do not need to manually replace \
with /
.
Using the upath.posix.*
namespace is not needed.
Also, upath
is not added to dependencies.
The file does not generate properly for me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm it does not work now.
It would be good to have unit test for Windows-specific paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Suggested merge commit message (convention)
Internal: Fixed automated tests entry point on Windows. Closes ckeditor/ckeditor5#17797.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.