T/56: Implemented CKEditorInspector#attachToAll()
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
ma2ciek
reviewed
Jul 4, 2019
|
The code looks good, I've just added a few comments. Could you bump up deps in this PR? OR rebase this PR on top of the latest CKEditor 5 deps so the CI will be green? |
|
This one is ready for another round of review @ma2ciek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Implemented the
CKEditorInspector#attachToAll()method. Closes #56.It requires #46 and latest CKEditor.