Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Angular tester #202

Closed
wants to merge 54 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
389458a
Get correct versions to test.
Dumluregn Jun 1, 2021
33e0841
Add creating Angular app.
Dumluregn Jun 2, 2021
4b92c25
Set up autotesting env.
Dumluregn Jun 9, 2021
258703f
Introduce 'noRebuild' option (nr).
Dumluregn Jun 17, 2021
cba84a4
Introduce proper testing and logging.
Dumluregn Jun 17, 2021
920d2f9
Remove unnecessary dependencies.
Dumluregn Jun 17, 2021
188bb35
Adjust copyFiles function to enable adjusting them per Angular version.
Dumluregn Jun 18, 2021
539ccb0
Ensure correct testing of all angular versions.
Dumluregn Jun 18, 2021
4187794
Improve logging.
Dumluregn Jun 18, 2021
afd348a
Enable testing target browser.
Dumluregn Jun 18, 2021
5e1ad16
Improve logging (before cleanup).
Dumluregn Jun 21, 2021
7d1211a
Improve logging (after cleanup).
Dumluregn Jun 21, 2021
d4a5a87
Extract Logger class.
Dumluregn Jun 21, 2021
e81148f
Extract some more logic.
Dumluregn Jun 21, 2021
7bacf26
Minor cleanup.
Dumluregn Jun 21, 2021
d9f312f
Log npm and npx commands.
Dumluregn Jun 21, 2021
e4978eb
Adjust logs if using prepared angular version.
Dumluregn Jun 21, 2021
98df801
Add TEST_APP_PATH const.
Dumluregn Jun 21, 2021
8c881ff
Improve logging array of tested versions.
Dumluregn Jun 21, 2021
08cf554
Add license banners.
Dumluregn Jun 21, 2021
85af9a7
Cleanup.
Dumluregn Jun 21, 2021
8f17a8d
Log path together with commands.
Dumluregn Jun 21, 2021
1391fcf
Move custom test files.
Dumluregn Jun 21, 2021
1fe22f7
Renaming.
Dumluregn Jun 21, 2021
f09b345
Improve logging.
Dumluregn Jun 21, 2021
1ff1fc5
Remove leftovers.
Dumluregn Jun 21, 2021
6e42bbe
Improve readability of banners.
Dumluregn Jun 21, 2021
9c49393
Change dest paths of files to copy.
Dumluregn Jun 21, 2021
f58baa7
Clarify some docs.
Dumluregn Jun 21, 2021
917e747
Enable testing with GH Actions.
Dumluregn Jun 21, 2021
36202e6
Remove angular-tests from .gitignore - it's created outside the repo.
Dumluregn Jun 22, 2021
6d92a70
Remove leftover.
Dumluregn Jul 16, 2021
1352f0e
Rename argument in getVersions() method.
Dumluregn Jul 16, 2021
3f6c0ec
Test latest angular/cli version if none was passed.
Dumluregn Jul 16, 2021
e757ade
Simplify getting the versions list by using the dist-tags of angular/…
Dumluregn Jul 16, 2021
9834a00
Downgrade karma-browserstack-launcher.
Dumluregn Jul 16, 2021
cbdec84
Remove unnecessary peerDependencies.
Dumluregn Jul 16, 2021
ca46cad
Remove italics from logger.
Dumluregn Jul 16, 2021
9bec8c8
Generalise the comment with versions.
Dumluregn Jul 16, 2021
7ea841a
Add karma-browserstack-launcher pkg
MMMalik Aug 3, 2021
6b2a2c8
Use build name from workflow
MMMalik Aug 3, 2021
c68b506
Use npx
MMMalik Aug 3, 2021
6a82910
Revert npx changes
MMMalik Aug 3, 2021
40479e4
Refactor test utils
MMMalik Aug 3, 2021
25da4b6
Remove integrations common
MMMalik Aug 3, 2021
650d124
Merge master into t/140
MMMalik Aug 3, 2021
9a8c11b
Remove unnecessary test script
MMMalik Aug 3, 2021
e96891a
Add ckeditor4-integrations-common to dev deps
MMMalik Aug 18, 2021
9b01535
Do not use next channel
MMMalik Aug 18, 2021
12d84e8
Adjust config for BrowserStack
MMMalik Aug 18, 2021
92f97bd
Merge branch 'master' into t/140
MMMalik Aug 18, 2021
d64a29d
Adjust karma config
MMMalik Aug 18, 2021
df83732
Do not expect drop event to have been called
MMMalik Aug 18, 2021
efaf66c
Adjust test env for IE11
MMMalik Aug 18, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Log npm and npx commands.
  • Loading branch information
Dumluregn committed Jul 16, 2021
commit d9f312faa2a4f164d90515c3823b5be9185d6b07
4 changes: 4 additions & 0 deletions scripts/_helpers/logger.js
Original file line number Diff line number Diff line change
@@ -23,6 +23,10 @@ module.exports = class Logger {
console.log( chalk.yellow( message ) + '\n' );
}

logCode( message ) {
console.log( chalk.italic.bold( message ) + '\n' );
}

logInfo( message ) {
console.log( message );
}
9 changes: 9 additions & 0 deletions scripts/_helpers/tools.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
const { execSync } = require( 'child_process' );
const { rmdirSync } = require( 'fs' );
const { resolve: resolvePath } = require( 'path' );
const { copySync } = require( 'fs-extra' );
const semverMajor = require( 'semver/functions/major' );
const Logger = require( './logger' );

const logger = new Logger();


/**
* Executes npm command.
@@ -13,6 +18,8 @@ const semverMajor = require( 'semver/functions/major' );
function execNpmCommand( command, cwd = __dirname ) {
const cmd = `npm ${command}`;

logger.logCode( cmd );

return execSync( cmd, {
encoding: 'utf-8',
cwd
@@ -30,6 +37,8 @@ function execNpmCommand( command, cwd = __dirname ) {
function execNpxCommand( command, cwd = __dirname ) {
const cmd = `npx ${command}`;

logger.logCode( cmd );

return execSync( cmd, {
encoding: 'utf-8',
cwd
2 changes: 1 addition & 1 deletion scripts/angular-tester.js
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ try {
}
} catch ( error ) {
logger.logWarning( error );
logger.logHeader( 'error', 'Unexpected error occured during testing - see the log above.' );
logger.logHeader( 'Unexpected error occured during testing - see the log above.' );

process.exit( 1 );
}