Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose API notifying about loaded CKEDITOR namespace #149

Merged
merged 15 commits into from
Mar 19, 2021
Merged

Expose API notifying about loaded CKEDITOR namespace #149

merged 15 commits into from
Mar 19, 2021

Conversation

Dumluregn
Copy link
Collaborator

@Dumluregn Dumluregn commented Nov 23, 2020 •
edited
Loading

Once the CKEDITOR namespace is loaded, we'll emit a namespaceLoaded event.

Testing this PR was a bit painful as there were issues with having multiple <ckeditor> components simultaneously (I reported ckeditor/ckeditor4#4390 to fix that in the future).

Closes #143.

@jacekbogdanski jacekbogdanski self-requested a review November 23, 2020 11:32
@jacekbogdanski jacekbogdanski self-assigned this Nov 23, 2020
jacekbogdanski
jacekbogdanski requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@jacekbogdanski jacekbogdanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing for me:
image

Also, please take a look at CI.

src/ckeditor/ckeditor.component.ts Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Dec 7, 2020
@github-actions
Copy link

There was no activity regarding this pull request in the last 14 days. We're closing it for now. Still, feel free to provide us with requested feedback so that we can reopen it.

@github-actions github-actions bot added the pr:frozen ❄ The pull request on which work was suspended due to various reasons. label Dec 14, 2020
@github-actions github-actions bot closed this Dec 14, 2020
@jacekbogdanski jacekbogdanski mentioned this pull request Dec 14, 2020
Open
@jacekbogdanski jacekbogdanski removed pr:frozen ❄ The pull request on which work was suspended due to various reasons. stale The issue / PR will be closed within the next 7 days of inactivity. labels Dec 14, 2020
@Dumluregn
Copy link
Collaborator Author

We should ensure that ckeditor-integrations-common content is transpiled to ES 5 to avoid IE11 issue like in ckeditor/ckeditor4-vue#75.

@github-actions
Copy link

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Dec 24, 2020
@github-actions
Copy link

There was no activity regarding this pull request in the last 14 days. We're closing it for now. Still, feel free to provide us with requested feedback so that we can reopen it.

@github-actions github-actions bot added the pr:frozen ❄ The pull request on which work was suspended due to various reasons. label Dec 31, 2020
@github-actions github-actions bot closed this Dec 31, 2020
@Dumluregn Dumluregn reopened this Jan 4, 2021
@Dumluregn Dumluregn removed pr:frozen ❄ The pull request on which work was suspended due to various reasons. stale The issue / PR will be closed within the next 7 days of inactivity. labels Jan 4, 2021
@github-actions
Copy link

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Jan 11, 2021
@Dumluregn Dumluregn removed the stale The issue / PR will be closed within the next 7 days of inactivity. label Jan 12, 2021
@Dumluregn Dumluregn self-assigned this Jan 13, 2021
@Dumluregn
Copy link
Collaborator Author

Rebased onto latest master.

@f1ames
Copy link
Contributor

f1ames commented Jan 15, 2021 •
edited
Loading

@Dumluregn should we mark it as blocked since it's waiting for ckeditor/ckeditor4-integrations-common#12? 🤔

@Dumluregn Dumluregn removed their assignment Feb 25, 2021
@github-actions
Copy link

github-actions bot commented Mar 5, 2021

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Mar 5, 2021
@Dumluregn Dumluregn removed the stale The issue / PR will be closed within the next 7 days of inactivity. label Mar 5, 2021
@github-actions
Copy link

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Mar 13, 2021
@Dumluregn Dumluregn removed the stale The issue / PR will be closed within the next 7 days of inactivity. label Mar 15, 2021
@jacekbogdanski jacekbogdanski self-requested a review March 16, 2021 08:39
jacekbogdanski
jacekbogdanski requested changes Mar 17, 2021
View reviewed changes
Copy link
Member

@jacekbogdanski jacekbogdanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dumluregn It seems like CI is failing after rebase. Could you check what's going on? It seems like some weird permission issue on windows.

@Dumluregn
Copy link
Collaborator Author

CI failed because of #72 and it seems that it caused an avalanche of the following errors.

jacekbogdanski
jacekbogdanski approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@jacekbogdanski jacekbogdanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! Good job @Dumluregn!

@jacekbogdanski jacekbogdanski merged commit a3e5362 into master Mar 19, 2021
@jacekbogdanski jacekbogdanski deleted the t/143 branch March 19, 2021 07:17
@CKEditorBot CKEditorBot mentioned this pull request Mar 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekbogdanski jacekbogdanski jacekbogdanski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose API notifying about loaded CKEDITOR namespace
4 participants
@Dumluregn @f1ames @jacekbogdanski @sculpt0r