Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the "onNamespaceLoaded" event #172

Open
Dumluregn opened this issue Feb 23, 2021 · 0 comments
Open

Add tests for the "onNamespaceLoaded" event #172

Dumluregn opened this issue Feb 23, 2021 · 0 comments
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@Dumluregn
Copy link
Collaborator

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

In #149 we replace the logic for getNamespace() method from this repo with an external one from https://github.com/ckeditor/ckeditor4-integrations-common (they're basically the same). We had however a number of issues trying to test cases with multiple editor instances (probably because of ckeditor/ckeditor4#4390). After it's fixed it would be good to come back to this and check if we can write proper tests.

@Dumluregn Dumluregn added status:confirmed An issue confirmed by the development team. size:S type:task Any other issue (refactoring, typo fix, etc). labels Feb 23, 2021
@jacekbogdanski jacekbogdanski modified the milestone: 2.2.0 Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Development

No branches or pull requests

2 participants