Search for deployment script in specified REPO_PATH_DIR #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapting the approach that is used in Civis's streamlit library here: https://github.com/civisanalytics/civis-services-streamlit/blob/main/entrypoint.sh#L7 This change is intended to make the Docker image more flexible for deployed services within Civis Platform, so that we can use it for arbitrary applications and directories. It still looks for an "start_service" shell script instead of just a Python app script, but that at least can be customized each user's need with this container.
|
This approach also seems to better match what is used in |
|
Thanks Bryan! These changes were included in #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting the approach that is used in Civis's streamlit library here: https://github.com/civisanalytics/civis-services-streamlit/blob/main/entrypoint.sh#L7
This change is intended to make the Docker image more flexible for deployed services within Civis Platform, so that we can use it for arbitrary applications and directories. It still looks for an "start_service" shell script instead of just a Python app script, but that at least can be customized each user's need with this container.
Targeted for issue #5