-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Swap out vendorized Jasmine runner for grunt-contrib-jasmine
We recently had some problems getting the spec suite to run in Travis CI, even on old commits where it once ran correctly. This seems to be happening because either a newer version of Node, npm, phantomjs, or Travis CI included a change that broke our setup. To fix this, and in hopes of making it more resilient for the future, I am swapping out my vendorized Jasmine runner for grunt-contrib-jasmine. At the same time, I added some JSHint to help keep things in check. This more or less followed the guide as written up at: http://travisjeffery.com/b/2013/09/testing-javascript-projects-with-grunt-jasmine-jshint/ Change-Id: If45b72461ddecd12acb20a674e2ac78016dc911b Reviewed-on: http://gerrit.causes.com/36753 Reviewed-by: Hao Su <[email protected]> Tested-by: Joe Lencioni <[email protected]>
- Loading branch information
Showing
10 changed files
with
52 additions
and
3,433 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"validthis" : true, | ||
"multistr" : true, | ||
"laxcomma" : true, | ||
"laxbreak" : true, | ||
"browser" : true, | ||
"eqeqeq" : false, | ||
"eqnull" : true, | ||
"debug" : true, | ||
"devel" : true, | ||
"curly" : false, | ||
"boss" : true, | ||
"expr" : true, | ||
"asi" : true, | ||
"supernew" : true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
language: node_js | ||
node_js: | ||
- "0.10" | ||
before_script: | ||
- npm install -g grunt-cli | ||
notifications: | ||
email: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* jshint node: true */ | ||
|
||
module.exports = function(grunt) { | ||
"use strict"; | ||
|
||
grunt.initConfig({ | ||
pkg: grunt.file.readJSON('package.json'), | ||
jshint: { | ||
all: [ | ||
"*.js", | ||
"spec/*.js" | ||
], | ||
options: { | ||
jshintrc: '.jshintrc' | ||
} | ||
}, | ||
jasmine: { | ||
src: "method-proxy.js", | ||
options: { | ||
specs: "spec/**/*.js" | ||
} | ||
} | ||
}); | ||
|
||
grunt.loadNpmTasks('grunt-contrib-jshint'); | ||
grunt.loadNpmTasks('grunt-contrib-jasmine'); | ||
|
||
grunt.registerTask('test', ['jshint', 'jasmine']); | ||
grunt.registerTask('default', ['test']); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.