Hotfix/address string array handling #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UPS now requires that TLS 1.2 be used when communicating the API.
The UPS API may return a string array instead of a single string value due to a bug in their serializer. The addition of another custom JsonConverter helps mitigate this. Only the first part of the returned string array will be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPS's API has a bug in their serializer where for the Street field it may return either
stringorstring[]similar to Candidate. I wrote a JsonConverter implementation that helps mitigate this by only grabbing thestring[]'s first value. It'd be easy to change this to do aString.Join(), but after seeing what's returned in multi-value situations, the other entries in the array were never useful.